MSC3861: MAS support #3493

mdnight · 2025-01-10T02:33:53Z

Pull Request Checklist

I have added Go unit tests or Complement integration tests for this PR or I have justified why this PR doesn't need tests
Pull request includes a sign off below using a legally identifiable name or I have already signed off privately

Signed-off-by: Roman Isaev <[email protected]>

i.e. /_synapse/admin/v1/users/{userID}/_allow_cross_signing_replacement_without_uia

If access token expires the client(i.e. element) expects a specific response with http code 401 and spec.UnknownToken

MAS requires this endpoint to fetch the data for the account management page

Extended logic of the endpoint in order to make it compatible with MAS

this change is based mostly on changes made in synapse https://github.com/element-hq/synapse/blob/develop/synapse/rest/client/keys.py#L392

Since MSC3861 is conflicting with standard reg/login flows, we require to disable them before running the server

these testcases are irrelevant msc3861 because access tokens are supposed to come from mas and access_token field is not used at all

…key_crosssigning.go

…_before_ms field

… comments

CLAassistant · 2025-01-10T02:33:59Z

All committers have signed the CLA.

mdnight · 2025-01-15T02:03:37Z

userapi/userapi_test.go

-		{
-			name:      "dupe token - ok",
-			inputData: &api.PerformDeviceCreationRequest{Localpart: "test3", ServerName: "test", AccessToken: dupeAccessToken, NoDeviceListUpdate: true},
-		},
-		{
-			name:      "dupe token - not ok",
-			inputData: &api.PerformDeviceCreationRequest{Localpart: "test3", ServerName: "test", AccessToken: dupeAccessToken, NoDeviceListUpdate: true},
-			wantErr:   true,
-		},


These tests are not relevant to msc3861 as access tokens are not involved in this flow

codecov-commenter · 2025-01-15T21:25:47Z

Codecov Report

Attention: Patch coverage is 49.90440% with 786 lines in your changes missing coverage. Please review.

Project coverage is 49.41%. Comparing base (add73ec) to head (3619a6d).

Files with missing lines	Patch %	Lines
clientapi/routing/admin.go	52.26%	153 Missing and 37 partials ⚠️
setup/mscs/msc3861/msc3861_user_verifier.go	48.27%	106 Missing and 29 partials ⚠️
clientapi/routing/key_crosssigning.go	12.29%	102 Missing and 5 partials ⚠️
clientapi/routing/routing.go	54.35%	24 Missing and 65 partials ⚠️
...as/2024123101150000_drop_primary_key_constraint.go	44.44%	29 Missing and 1 partial ⚠️
...erapi/storage/postgres/cross_signing_keys_table.go	50.84%	22 Missing and 7 partials ⚠️
...serapi/storage/sqlite3/cross_signing_keys_table.go	50.84%	22 Missing and 7 partials ⚠️
clientapi/routing/profile.go	12.50%	18 Missing and 3 partials ⚠️
userapi/storage/shared/storage.go	58.69%	13 Missing and 6 partials ⚠️
setup/config/config_clientapi.go	54.28%	14 Missing and 2 partials ⚠️
... and 19 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3493      +/-   ##
==========================================
+ Coverage   49.39%   49.41%   +0.01%     
==========================================
  Files         524      533       +9     
  Lines       59737    60985    +1248     
==========================================
+ Hits        29507    30133     +626     
- Misses      26748    27258     +510     
- Partials     3482     3594     +112

Flag	Coverage Δ
unittests	`49.41% <49.90%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mdnight added 30 commits December 21, 2024 01:00

mas: added /auth_issuer endpoint

ba542fe

mas: added username_available endpoint

2c47959

mas: rename msc2965 to msc3861

e1dfe62

mas: added localpart_external_ids table

150be58

mas: first successful attempt of login with via mas

63a199c

mas: added "admin's replacement without uia" endpoint

9d9841d

i.e. /_synapse/admin/v1/users/{userID}/_allow_cross_signing_replacement_without_uia

minor goimports fix

4f406e2

mas: return correct http code

b950703

If access token expires the client(i.e. element) expects a specific response with http code 401 and spec.UnknownToken

another goimports fix

9ebcebe

mas: implemented PUT /admin/v2/users/{userID} endpoint

be8d490

MAS requires this endpoint to fetch the data for the account management page

mas: add AccountTypeOIDCService

524f65c

mas: modify PUT /profile/{userID}/displayname endpoint

ff63e7f

Extended logic of the endpoint in order to make it compatible with MAS

drop primary key constraint from userapi_devices.access_token

bf310d5

mas: refactor admin user device handler

f4ff426

mas: added admin's delete devices endpoint

803cce8

mas: minor fixes in cross_signing_keys_table files

7ffb2c1

refactor logger calls

c06e0aa

mas: added /admin/v1/deactivate/{userID} endpoint

48f3cd3

minor refactoring

9b064b1

mas: added support of msc3861 to /keys/device_signing/upload endpoint

cc7deb2

this change is based mostly on changes made in synapse https://github.com/element-hq/synapse/blob/develop/synapse/rest/client/keys.py#L392

mas: fix displayname handling

5cffc2c

mas: handle 3pids from mas

811a504

mas: acced msc3861 config example to the dendrite-sample.yaml

17576cc

mas: fail if conflicts in config occur

e943ba5

Since MSC3861 is conflicting with standard reg/login flows, we require to disable them before running the server

mas: reorganise endpoints

7eec60e

unit tests fix

fb15db7

Bump golang version

b44a79c

more fixes

7311d3e

linter fixes

0990676

fix cross_signing_keys_table

1afe2b9

mdnight added 7 commits January 9, 2025 02:15

deleted test cases TestDevices/sqlite/dupe_token

244021d

these testcases are irrelevant msc3861 because access tokens are supposed to come from mas and access_token field is not used at all

++

78457f3

fix syncapi tests

80ee52e

mas: move org.matrix.cross_signing_reset const from logintypes.go to …

930daa1

…key_crosssigning.go

syncapi_test.go fix

0be9b3c

mas: add missing migration for adding x-signing updatable_without_uia…

4cde3ba

…_before_ms field

mas: remove enabled field from msc3861 config + remove some incorrect…

5ea033d

… comments

mdnight added 2 commits January 10, 2025 23:42

Add TestMakeServiceAdminAPI

5fd654f

mas: add TestVerifyUserFromRequest

5914661

mdnight commented Jan 15, 2025

View reviewed changes

mdnight added 8 commits January 15, 2025 03:21

mas: TestAdminCheckUsernameAvailable

90e3de3

mas: TestAdminUserDeviceRetrieveCreate

59f73b1

mas: TestAdminUserDeviceDelete

f1de5aa

mas: TestAdminUserDevicesDelete

0db7647

mas: TestAdminDeactivateAccount

4193b7b

mas: TestAdminRetrieveAccount

e8902da

mas: TestAdminCreateOrModifyAccount

5dd8568

mas: TestAdminAllowCrossSigningReplacementWithoutUIA

418c584

mdnight marked this pull request as ready for review January 15, 2025 19:02

mdnight requested a review from a team as a code owner January 15, 2025 19:02

mdnight changed the title ~~WIP: MSC3861: MAS support~~ MSC3861: MAS support Jan 15, 2025

mas: refactoring

3619a6d

mdnight force-pushed the msc3861 branch from 5280b4f to 3619a6d Compare January 15, 2025 19:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MSC3861: MAS support #3493

MSC3861: MAS support #3493

mdnight commented Jan 10, 2025

CLAassistant commented Jan 10, 2025 •

edited

Loading

mdnight Jan 15, 2025

codecov-commenter commented Jan 15, 2025

MSC3861: MAS support #3493

Are you sure you want to change the base?

MSC3861: MAS support #3493

Conversation

mdnight commented Jan 10, 2025

Pull Request Checklist

CLAassistant commented Jan 10, 2025 • edited Loading

mdnight Jan 15, 2025

Choose a reason for hiding this comment

codecov-commenter commented Jan 15, 2025

Codecov Report

CLAassistant commented Jan 10, 2025 •

edited

Loading